feat(webapp): alternative solution for filter and order posts #6367
Conversation
- Unset post type filter menu button by clicking a set button.
…lot-Social into 6190-extend-newsfeed-filter-menu-for-events
…lot-Social into 6190-extend-newsfeed-filter-menu-for-events
This reverts commit 4050d8d.
…cial into 6190-extend-newsfeed-filter-menu-for-events
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
….js' to the files where it's used
…cial into 6190-extend-newsfeed-filter-menu-for-events
…the event start date
There was a problem hiding this comment.
Even if I'm not allowed to do so by our rules …
I give you my approve and thank you that you made the store lighter and much more clearly as well as the tests slim. 🙏🏼 🚀🚀💫💫
I love it! 😍
Would be nice if you give a good hint here in the description to my PR #6341 and what it has todo with mine.
And I will do as well on mine if I close it.
PS: For transparence of our talk and because I feel I need to express my feelings to the team.
My PR came late. Sorry for that, but I was prepared to work on the weekend.
Like I said:
My PR was in a prereview state, because I was not satisfied with it and liked to go ahaead working on it. I got not the chance to better and improve my code myself and have a learning by doing or by having a pairing with you.
Because you throw my tests completetly I lost a half day of my work which makes me bad feelings as well.
I would've liked better if you have talked to me before you worked on my issue and code silently.
I'm sure we would have found a solution and you could have worked on my PR, instead of open a new one. That gave me the impression that I just do bullshit and that we are more in a kind of competition, even if you wrote on Discord that we are not.
Thanks for your explanation, your excuse, and for expressing your worries todo so in our talk.
And that we all will try todo better in the future.
I like always to learn and be very interested to have a good code base, that both is my main interest.
🍰 Pullrequest
Issues
Todo