Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): fix event teaser date from start to end by new components #6385

Merged
merged 18 commits into from
Jun 8, 2023

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Jun 7, 2023

🍰 Pullrequest

Fix event teaser date from start to end by new components.

Issues

Todo

  • create component for date range
  • create component for location

@Tirokk Tirokk changed the base branch from master to merge-6336-into-6339-optimize-event-create-and-update June 7, 2023 12:19
@Tirokk Tirokk requested review from Elweyn, maeckes1 and ogerly June 7, 2023 15:10
@Tirokk Tirokk self-assigned this Jun 7, 2023
@Tirokk Tirokk added bug Something isn't working service: webapp labels Jun 7, 2023
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Jun 7, 2023
…of github.com:Ocelot-Social-Community/Ocelot-Social into 6379-fix-event-teaser-date-from-start-to-end
webapp/components/DateTimeRange/DateTimeRange.vue Outdated Show resolved Hide resolved
webapp/components/DateTimeRange/DateTimeRange.vue Outdated Show resolved Hide resolved
@Tirokk
Copy link
Member Author

Tirokk commented Jun 7, 2023

I find this ugly and have to talk about. @Elweyn @maeckes-infinitylabs @ogerly

Bildschirmfoto 2023-06-07 um 20 04 44

Tirokk and others added 2 commits June 7, 2023 20:10
Co-Authored-By: Mogge <moriz.wahl@gmx.de>
…of github.com:Ocelot-Social-Community/Ocelot-Social into 6379-fix-event-teaser-date-from-start-to-end
@Tirokk Tirokk requested a review from Mogge June 7, 2023 18:18
…of github.com:Ocelot-Social-Community/Ocelot-Social into 6379-fix-event-teaser-date-from-start-to-end
@Elweyn
Copy link
Member

Elweyn commented Jun 8, 2023

image

Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make follow issue for Unit Test of the components

@Tirokk
Copy link
Member Author

Tirokk commented Jun 8, 2023

Please make follow issue for Unit Test of the components

Done here #6407

…of github.com:Ocelot-Social-Community/Ocelot-Social into 6379-fix-event-teaser-date-from-start-to-end
Base automatically changed from merge-6336-into-6339-optimize-event-create-and-update to master June 8, 2023 18:14
@Tirokk Tirokk merged commit 2b7cdaa into master Jun 8, 2023
20 checks passed
@Tirokk Tirokk deleted the 6379-fix-event-teaser-date-from-start-to-end branch June 8, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service: webapp
Projects
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Webapp – Event Teaser – Date from Start to End
3 participants