Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): chat - do not allow to create room with self #6530

Merged
merged 3 commits into from
Jul 11, 2023
Merged

fix(backend): chat - do not allow to create room with self #6530

merged 3 commits into from
Jul 11, 2023

Conversation

ulfgebhardt
Copy link
Member

🍰 Pullrequest

chat - do not allow to create room with self

Issues

  • None

Todo

  • None

@ulfgebhardt ulfgebhardt self-assigned this Jul 11, 2023
@ulfgebhardt ulfgebhardt requested a review from Elweyn July 11, 2023 09:19
@ulfgebhardt ulfgebhardt mentioned this pull request Jul 11, 2023
Closed
1 task
Elweyn
Elweyn requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a Unit Test in Backend to not allow to create room with myself 😅

@ulfgebhardt ulfgebhardt merged commit ab5b7a0 into master Jul 11, 2023
20 checks passed
@ulfgebhardt ulfgebhardt deleted the fix-backend-room-with-self branch July 11, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn approved these changes

@ogerly ogerly Awaiting requested review from ogerly

Assignees

@ulfgebhardt ulfgebhardt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ulfgebhardt @ogerly @Elweyn