refactor(webapp): refactor filter menu #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elweyn
requested changes
Jul 12, 2023
|
|
|
I updated the UI:
|
|
Next proposal:
|
…cial into 6500-refactor-filter-menu
Tirokk
previously requested changes
Jul 26, 2023
There was a problem hiding this comment.
Looks really cool! @maeckes-infinitylabs 😍
But I have to request changes. A little I made my self.
The following are hint texts instead of label texts and not all of them I made a code suggestion for:
Just in case there is time for it. Otherwise we do it in the next release. No problem:
See issue #6644
…Community/Ocelot-Social into 6500-refactor-filter-menu
|
Somehow it is strange in german cause of "Veranstalltung" is so long: |
|
added feedback and the padding for the filter list |
Elweyn
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Makes some visual adjustments and text updates for filter menu
Issues
AllButton in front of Sources like in front of the Topics #6644Todo