Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): add missing locales #6652

Merged
merged 4 commits into from
Aug 2, 2023
Merged

fix(webapp): add missing locales #6652

merged 4 commits into from
Aug 2, 2023

Conversation

Elweyn
Copy link
Member

@Elweyn Elweyn commented Jul 31, 2023

馃嵃 Pullrequest

The notification in the header menu had no localisation.
This PR adds the localisation for German, English and French.

Issues

  • None

Todo

  • Add notifications.headerMenuButton.tootltip

@Elweyn Elweyn self-assigned this Jul 31, 2023
Copy link
Contributor

@mahula mahula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other languages?

mahula
mahula previously approved these changes Aug 2, 2023
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have to place the question if we should name the hint like it was before it got broken?

webapp/locales/de.json Outdated Show resolved Hide resolved
webapp/locales/en.json Outdated Show resolved Hide resolved
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 馃崁

I approve 馃殌馃挮

@mahula mahula merged commit e8bffd7 into master Aug 2, 2023
24 checks passed
@mahula mahula deleted the fix-missing-locales branch August 2, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants