Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): try to fix avatars #6660

Merged
merged 4 commits into from
Aug 9, 2023
Merged

fix(webapp): try to fix avatars #6660

merged 4 commits into from
Aug 9, 2023

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Aug 7, 2023

🍰 Pullrequest

Try to fix avatars.

Issues

Todo

  • None

@Tirokk Tirokk requested review from ulfgebhardt and Elweyn and removed request for ulfgebhardt August 7, 2023 16:21
@Tirokk Tirokk added the bug Something isn't working label Aug 7, 2023
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Aug 7, 2023
Elweyn
Elweyn requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the user profil picture in the chat room, but the room doesn't get the image!
image

Elweyn
Elweyn previously approved these changes Aug 8, 2023
View reviewed changes
Tirokk
Tirokk commented Aug 8, 2023
View reviewed changes
Copy link
Member Author

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works most of the time.
Only if I scroll up in the messages until relead then the old message avatars do disappear.

Bildschirmfoto 2023-08-08 um 15 13 20 Bildschirmfoto 2023-08-08 um 15 13 35

@Elweyn Elweyn merged commit f933bd2 into master Aug 9, 2023
24 checks passed
@Elweyn Elweyn deleted the try-to-fix-avatars branch August 9, 2023 09:24
@Tirokk Tirokk mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn approved these changes

Assignees

@ulfgebhardt ulfgebhardt

Labels
bug Something isn't working
Projects
Kanban Board Ocelot-Social Software
Status: Done
Milestone
🏃 The Sprint after that...
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tirokk @Elweyn @ulfgebhardt