Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): metascraper crash #6704

Merged
merged 7 commits into from
Sep 8, 2023
Merged

fix(backend): metascraper crash #6704

merged 7 commits into from
Sep 8, 2023

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Sep 5, 2023

@Tirokk Tirokk changed the title Fix(backend): metascraper crash fix(backend): metascraper crash Sep 6, 2023
@mahula
Copy link
Contributor

mahula commented Sep 7, 2023

Updating the metascraper packages to major version 5 throws a follow-up error related to package dependencies:

Error [ERR_REQUIRE_ESM]: require() of ES Module /app/node_modules/wrap-ansi/index.js from /app/node_modules/cliui/build/index.cjs not supported.
Instead change the require of index.js in /app/node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules.

For several reasons it is under discussion to change to another scraper.
Therefore, for the moment it is sufficient to accept the removal of the audio scraper as a solution to the crash problem - without updating the scraper libraries to the next major version.

@mahula mahula self-assigned this Sep 7, 2023
@mahula mahula added bug Something isn't working service: backend dependencies labels Sep 7, 2023
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ulfgebhardt ,

we had a backend test crash with your updates of all the meta-scrapers which @mahula couldn't solve quickly. Therefore he reverted the updates.

The reson because of @Elweyn and I couldn't save the post @mahula put in the new issue #6712 .

Now it works an I approve.

Great that you both did this. 🤗😍

@Tirokk Tirokk merged commit a47600f into master Sep 8, 2023
24 checks passed
@Tirokk Tirokk deleted the fix-metascraper-crash branch September 8, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💥 [DevOps] Backend - We have Several Restarts on the Kubernetes Backend on Yunite.me
3 participants