Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): event date format #6784

Merged
merged 12 commits into from
Nov 2, 2023
Merged

fix(webapp): event date format #6784

merged 12 commits into from
Nov 2, 2023

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Oct 9, 2023

🍰 Pullrequest

Issues

Todo

  • migration to fix dates on server

@Mogge Mogge self-assigned this Oct 9, 2023
@Mogge Mogge added service: webapp bug Something isn't working labels Oct 9, 2023
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a migration of the DB? @Mogge

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does work on Safari and Firefox. 👍🏼

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • care for the summer and winter time @ulfgebhardt
    • may we can use the creation date to distinguish between it?
    • !!! we decided to set winter time in the migration !!!
  • give a backend error if the frontend sends not UTC datetime? @Mogge

Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should define a time before this transformation happens and one after this will not happen.
if(post.createdAt is before XXX)

If we should do the extra effort to calculate the summer and winter offset is not important to me.

I do not fully understand if the problem is solved with the Conversion to Date - i assume it takes the given timezone and converts it to UTC, but thats an assumption.

Tirokk
Tirokk previously approved these changes Oct 26, 2023
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works excelent. @Mogge

Therefore I approve 🚀🚀💫💫

PS: I tested the error message in the browser as well. Cool! 😍
PPS: And you already corrected the hour offset. 👍🏼

@Tirokk
Copy link
Member

Tirokk commented Oct 26, 2023

!!! Before we merge we have to prepare the stage.yunite.me to test the migration on the server !!!

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very good idea to take the migration out of the coverage. 👍🏼

@Tirokk
Copy link
Member

Tirokk commented Nov 2, 2023

!!! Before we merge we have to prepare the stage.yunite.me to test the migration on the server !!!

@Tirokk
Copy link
Member

Tirokk commented Nov 2, 2023

Test migration on stage.yunite.me by:

  • removing the automatic seeding in publish
  • entering the database cypher shell via Kubernetes
  • run the folling commands before and after merging this PR into the master and auto deployment:
MATCH (event:Event) WHERE NOT event.eventStart CONTAINS 'T' RETURN event.id, event.eventStart, event.eventEnd;

Or:

MATCH (event:Event) RETURN event.id, event.eventStart, event.eventEnd;

@Tirokk Tirokk merged commit 23538fd into master Nov 2, 2023
24 checks passed
@Tirokk Tirokk deleted the fix-event-date-format branch November 2, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service: webapp
Projects
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Events – On set Event Filter an Event of the same Day is not Visible
3 participants