Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python logging instead of custom class. #45

Merged
merged 2 commits into from
Jun 20, 2016
Merged

Conversation

cmutel
Copy link
Member

@cmutel cmutel commented Jun 17, 2016

Fixes #39.

Several clear advantages:

  • Don't have to pass custom logger class to transformation functions
  • Separation of previous Logger class into OutputDir (which creates the output directory), and create_log, which creates the log.
  • Standard logging allows for plugging into library functions and package ecosystem, e.g. shipping logs.

Plus there is generally less magic.

Docs are updated, tests pass on my machine and CI.

@cmutel
Copy link
Member Author

cmutel commented Jun 17, 2016

@ecoinvent Please check and merge if you are fine with these changes.

@coveralls
Copy link

coveralls commented Jun 17, 2016

Coverage Status

Coverage increased (+0.2%) to 61.79% when pulling fc1d379 on real-logging into b03bbbd on master.

@ecoinvent ecoinvent merged commit 784b338 into master Jun 20, 2016
@cmutel cmutel deleted the real-logging branch June 20, 2016 09:22
@cmutel cmutel restored the real-logging branch August 2, 2016 08:30
@cmutel cmutel deleted the real-logging branch August 8, 2016 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants