Allow PHP ^8.0, drop PHP 7.3

[fezfez]

Note :

roave/backward-compatibility-check has been drop because it does not support PHP:^8.0 and he his not used in CI (probably only in local)

Thanks for your awesome work 🚀 🌈 !

[fezfez]

@Ocramius : 8.0 job seem to fail with locked deps because of infection/infection 0.15.3, there are two solution, drop locked tests or drop php 7.3. i believe your policy is to drop php version that are not in active support so i drop php 7.3.

[fezfez]

@Ocramius : infection does not like phpunit deprecation "at" and i dont find a clean solution, i replaced at by "once" ....

[fezfez]

i got this error with infection.

PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.12 with PCOV 1.0.6
Configuration: /tmp/infection/phpunitConfiguration.initial.infection.xml
Random seed:   1607512606

...............R..............                                    30 / 30 (100%)

Time: 00:00.110, Memory: 14.00 MB

There was 1 risky test:

1) DoctrineBatchUtilsTest\BatchProcessing\SimpleBatchIteratorAggregateTest::testIterationRollsBackOnMissingItems
This test executed code that is not listed as code to be covered or used:
- DoctrineBatchUtils\BatchProcessing\Exception\MissingBatchItemException::fromInvalidReference

OK, but incomplete, skipped, or risky tests!
Tests: 30, Assertions: 57, Risky: 1.

Have you an idea ?

[Ocramius]

Hmm, the exception should probably be listed under @uses.

Without running infection, you can reproduce these warnings with vendor/bin/phpunit --coverage-text

[fezfez]

@Ocramius thanks 👍

So now tests are green, PR contains :

• allow PHP ^8.0
• drop PHP 7.3
• allow doctrine/orm ^2.8
• move to phpunit ^9.5
• move phpunit.xml schema to 9.3
• remove deprecated "at" in phpunit
• move to infection ^0.20.2
• typed properties 🥇
• drop roave/backward-compatibility-check 👎

[Ocramius]

@fezfez excellent work, but I did indeed find multiple things that do need adjustment :S

[Ocramius]

Besides some minor changes needed in tests and file permissions, this looks very close to what is needed to get us to PHP 8 :D

[Ocramius]

I've mentioned this previously: this clear() must be called after the other invocations

[fezfez]

I have fixed this test but i think it is really messy, have you a more clean solution ?

[Ocramius]

It's messy, but it is indeed required. The best we can do is isolating the stub creation to a private method.

Further refactoring can be deferred to a later point in time: for now, this (IMO) works well enough.

[Ocramius]

@fezfez for the purposes of this patch, I'd say:

1. clean up the last CS checks
2. open a new issue to clean up UoW/EntityManager stubs in a separate task that somebody else can take on

[fezfez]

@Ocramius : done. curious to see a more clean solution.

[Ocramius]

Excellent, thanks @fezfez!