Adds configuration for the hydrator on a per property basis #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TravisCI failures seem to be of stylistic nature ... I would like this PR to be merged in order to further enhance the GeneratedHydrator code |
| * | ||
| * @param type $allowedProperties | ||
| */ | ||
| private function expandAllowedProperties($options) |
| $propertyData = '$data["\\0*\\0' . $propertyName . '"]'; | ||
| } | ||
|
|
||
| $body .= 'if (isset(' . $propertyData . ")) {\n" |
There was a problem hiding this comment.
This is a bit doubtful if i need to check if the object property is set before i can extract it.. not sure what to do here
|
@flip111 can you add unit tests for this changes? |
|
| * | ||
| * @param array $options | ||
| */ | ||
| private function expandAllowedProperties($options) |
1. moved information on properties outside of the HydratorMethodsVisitor into the HydratorGenerator 2. moved exception code into it's own class InvalidOptionException 3. moved option parsing from HydratorMethodsVisitor to value object AllowedPropertiesOption 4. small fix where a null would not be hydrated (in case the object itself has another default value)
|
@Ocramius any more fundamental remarks on this PR? Please let me know, then i will proceed with unit tests and wrap this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design: #16 (comment)
Unit tests will follow after design approval