Use php-parser v3 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also for this one, we should have newest/stable dependency testing, as per Ocramius/CodeGenerationUtils#9 (comment) |
|
Sure, just to say I haven't forgotten about this. Its on my todo list still. |
|
No worries!
…On 26 Jun 2017 5:07 PM, "Gavin Staniforth" ***@***.***> wrote:
Sure, just to say I haven't forgotten about this. Its on my todo list
still.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakHXHB8glqMT00YBFO099yLLOmdjKks5sH8kigaJpZM4OBoTE>
.
|
gsdevme
force-pushed
the
use-php-parser-3
branch
from
9bba8ed
to
3de9ef2
Compare
gsdevme
force-pushed
the
use-php-parser-3
branch
from
3de9ef2
to
58258ad
Compare
gsdevme
force-pushed
the
use-php-parser-3
branch
from
58258ad
to
f14429d
Compare
|
@gsdevme a bump in the phpunit version is needed (can use latest 5.x version) |
Ocramius
requested changes
Jun 30, 2017
composer.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "zendframework/zend-hydrator": "^2.0" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "~5.0", | |||
| "phpunit/phpunit": "^5.0", | |||
There was a problem hiding this comment.
You will need to specify something like ^5.7.21
|
Okay thanks, sorry slowest PR in history. I'm side tracked a lot 😂
…Sent from my iPhone
On 30 Jun 2017, at 09:03, Marco Pivetta ***@***.***> wrote:
@Ocramius requested changes on this pull request.
In composer.json:
> @@ -25,7 +25,7 @@
"zendframework/zend-hydrator": "^2.0"
},
"require-dev": {
- "phpunit/phpunit": "~5.0",
+ "phpunit/phpunit": "^5.0",
You will need to specify something like ^5.7.21
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@gsdevme "slowest PR in history"?! I got some PRs hanging around since 2012 :-P |
|
Haha okay. I will proceed with it and tonight anyway 😁
…Sent from my iPhone
On 30 Jun 2017, at 09:21, Marco Pivetta ***@***.***> wrote:
@gsdevme "slowest PR in history"?! I got some PRs hanging around since 2012 :-P
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
gsdevme
force-pushed
the
use-php-parser-3
branch
from
ac831e9
to
07312c6
Compare
|
Not sure what scrutinizer is complaining about here? |
|
I think it failed due to the rebase - not a problem :-) |
|
LGTM 👍 Thanks @gsdevme! |
Ocramius
approved these changes
Jul 4, 2017
|
Thanks for merging & the library 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This uses my forked version of CodeGenerationUtils which supports PHP parser v3 (PR for that). The tests are passing, the very simple app I have continues to work but its very possible its not 100% BC.
Would you prefer to keep support for both
2.0|3.0? If so I should likely edit the Travis to do a matrix like for --prefer-lowest etc.Solves #67
Will rebase once the dependencies are sorted/tagged