Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

.less files are served with Content-Type: text/less #1

Closed
Ocramius opened this issue May 27, 2011 · 3 comments
Closed

.less files are served with Content-Type: text/less #1

Ocramius opened this issue May 27, 2011 · 3 comments
Assignees

Comments

@Ocramius
Copy link
Owner

The Minify library reserves text/css for recognizing CSS files to be compressed (thus, ignoring LESS parsing). This makes it quite difficult to compress .less files and change the output header after compression.
Will look around for hooks where to fix all this stuff...
Anyway, I think we really need some Minify 3.0 with some better way of defining adapters... Minify classes are too thightly coupled with each other!

@ghost ghost assigned Ocramius May 27, 2011
@mrclay
Copy link

mrclay commented Jun 3, 2011

You want to edit Minify_Source so it marks *.less files with contentType = "text/css", and minifier = array('LessCss_Minify' ,'minify').

True about Minify being too coupled. The 2.2 branch has some work started on this, but it's not at all functional. Another thing to look at is Assetic. Looks like a 5.3 Minify killer :)

@Ocramius
Copy link
Owner Author

Ocramius commented Jun 3, 2011

Thank you for the hints!
I'll take a look at assetic, anyway I still think that your minify is great work, but that it could be really enhanced by some "ok, let's start over" :)
I already tried with text/css thingy in Minify_Source, but didn't work for me, or, at least, it tried to rework any .css file as if it was less!
Will see how 2.2 works, and also check if I can work on it this weekend...
Will keep the issue updated... Also, let me know if these features could be dropped into the official minify package if they become stable enough...

@Ocramius
Copy link
Owner Author

Won't fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants