Remove double registration of the event listeners

Composer already registers listeners when the plugin class implements EventSubscriberInterface
Ocramius · Jul 22, 2016 · 7dea49e · 7dea49e
1 parent b300ac2
commit 7dea49e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/PackageVersions/Installer.php b/src/PackageVersions/Installer.php
@@ -57,7 +57,7 @@ public static function getVersion(string $packageName) : string
      */
     public function activate(Composer $composer, IOInterface $io)
     {
-        $composer->getEventDispatcher()->addSubscriber($this);
+        // Nothing to do here, as all features are provided through event listeners
     }
 
     /**

diff --git a/test/PackageVersionsTest/InstallerTest.php b/test/PackageVersionsTest/InstallerTest.php
@@ -44,7 +44,7 @@ final class InstallerTest extends PHPUnit_Framework_TestCase
 
     /**
      * {@inheritDoc}
-     * 
+     *
      * @throws \PHPUnit_Framework_Exception
      */
     protected function setUp()
@@ -59,13 +59,6 @@ protected function setUp()
         $this->composer->expects(self::any())->method('getEventDispatcher')->willReturn($this->eventDispatcher);
     }
 
-    public function testActivate()
-    {
-        $this->eventDispatcher->expects(self::once())->method('addSubscriber')->with($this->installer);
-
-        $this->installer->activate($this->composer, $this->io);
-    }
-
     public function testGetSubscribedEvents()
     {
         $events = Installer::getSubscribedEvents();
@@ -299,7 +292,7 @@ public static function getVersion(string $packageName) : string
 
     /**
      * @group #12
-     * 
+     *
      * @throws \RuntimeException
      */
     public function testDumpVersionsWithoutPackageSourceDetails()