Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages don't always have a source/reference #12

Closed
Ocramius opened this issue Feb 18, 2016 · 4 comments
Closed

Packages don't always have a source/reference #12

Ocramius opened this issue Feb 18, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@Ocramius
Copy link
Owner

Moved from Ocramius/ProxyManager#294

Basically, when using something like following:

{
    "require": {
        "jquery/jquery":  "1.10.*"
    },
    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "jquery/jquery",
                "version": "1.10.2",
                "dist": {
                    "url": "http://code.jquery.com/jquery-1.10.2.js",
                    "type": "file"
                }
            }
        }
    ]
}

As you can see, this package has no source reference, as it comes from a repository (in-lined in the composer.json) that has no such information. Therefore, this call fails, causing a general failure of the code generation in the script.

@Ocramius Ocramius added the bug label Feb 18, 2016
@Ocramius Ocramius added this to the 1.0.2 milestone Feb 18, 2016
Ocramius added a commit that referenced this issue Feb 18, 2016
Ocramius added a commit that referenced this issue Feb 18, 2016
Ocramius added a commit that referenced this issue Feb 18, 2016
Ocramius added a commit that referenced this issue Feb 24, 2016
…-package-version-references

Fix #12 - support dist and missing package version references
@magnetik
Copy link

yay ! Do you mind tagging a new version (in the 1.x branch)?

@Ocramius
Copy link
Owner Author

@magnetik yarp, gonna happen now.

@Ocramius Ocramius self-assigned this Feb 24, 2016
@Ocramius
Copy link
Owner Author

@magnetik released

@magnetik
Copy link

Awesome, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants