#101 corrected scanned locations for installed.json and composer.json
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son` Due to `getcwd()` returning an empty string in some environments, (or even `"."`, a dot, sometimes), this fallback versions logic was too fragile. Adding hardcoded paths that are supposed to be constant (relative to the installation path of `FallbackVersions.php`) gives us more stability.
Otherwise, composer cannot determine the current branch-alias, and fails early during installation.
Ocramius
force-pushed
the
fix/#101-correct-fallback-versions-behavior-with-no-scripts-installation
branch
2 times, most recently
from
b46d6c1
to
cfd925d
Compare
Ocramius
force-pushed
the
fix/#101-correct-fallback-versions-behavior-with-no-scripts-installation
branch
from
cfd925d
to
1053ea0
Compare
Ocramius
deleted the
fix/#101-correct-fallback-versions-behavior-with-no-scripts-installation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
getcwd()returning an empty string in some environments, (or even".", a dot, sometimes), this fallback versions logic was too fragile.Adding hardcoded paths that are supposed to be constant (relative to the installation path of
FallbackVersions.php) gives us more stability.Fixes #101