Fix incorrect lookup path for installed.json
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hey @arondeparon, please also backport the tests :S My suggestion is to use |
|
Will do! I did not see the backport yet and wrote the exact same fix as you already did 😉 |
…son` Due to `getcwd()` returning an empty string in some environments, (or even `"."`, a dot, sometimes), this fallback versions logic was too fragile. Adding hardcoded paths that are supposed to be constant (relative to the installation path of `FallbackVersions.php`) gives us more stability.
Otherwise, composer cannot determine the current branch-alias, and fails early during installation.
|
@arondeparon about 03e5174, I think |
|
@Ocramius yeah I was not entirely sure about how you would like to see it, but noticed that I'll change the test to be a bit more flexible 👌 |
|
Tests passing now 😃 |
Ocramius
approved these changes
Nov 15, 2019
|
LGTM! 👍 |
Ocramius
changed the title
installed.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that cause Laravel installations with a dependency on
1.4.xto break that are installed usingcomposer install --no-scriptsas described in #112