Rewrote package to use composer-runtime-api:^2.0 and no longer keep an internal generated map
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an internal generated map This massively simplifies the whole design, as it allows us to get rid of most of the complexity of the package. Sadly, due to the API of `Versions::ROOT_PACKAGE_NAME`, we still need to generate code during installation, and the composer plugin needs to be maintained long-term, but overall we can deprecate its usage, and endorse moving to `composer/composer:^2.0.0`.
This constant is the only reason why this package still needs to exist as a composer plugin: removing it allows releasing a new major version that no longer needs to modify files post-installation.
… replaced by mutation test + type coverage
…permutations during composer installation
…ow `branch-alias` recognition This allows deeper dev-dependencies, which do rely on `ocramius/package-versions` themselves, to be installed. Without this, the current active branch has no stable version, and dependencies can no longer detect it as compatible.
…ugs are out of scope for this package
…, which is (fairly) pure/immutable
This was referenced Jul 11, 2020
1 task
1 task
| */ | ||
| public const VERSIONS = %s; |
There was a problem hiding this comment.
@Ocramius It seems like removing this seems to break compatibility to ocramius/proxy-manager:2.8
I get the following error:
!! Fatal error: Uncaught Error: Undefined class constant 'VERSIONS' in /tmp/sulu-develop.localhost/vendor/ocramius/proxy-manager/src/ProxyManager/Generator/Util/IdentifierSuffixer.php:50
There was a problem hiding this comment.
Fairly sure that's my own fault inside ocramius/proxy-manager then: can you report an issue there, please?
There was a problem hiding this comment.
Note: this was @internal before, so I shouldn't have relied on it in first place.
There was a problem hiding this comment.
Oh I see make sense then that it need to be changed at the proxy-manager side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This massively simplifies the whole design, as it allows us to get rid of most of the complexity
of the package. Sadly, due to the API of
Versions::ROOT_PACKAGE_NAME, we still need to generatecode during installation, and the composer plugin needs to be maintained long-term, but overall
we can deprecate its usage, and endorse moving to
composer/composer:^2.0.0.