BC break: removed deprecated PackageVersions\Versions::ROOT_PACKAGE_NAME constant
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will probably need to remove some error suppression from the current tests to see why they're failing 🤷 |
…NAME` constant This simplifies the tool to no longer be a plugin: `PackageVersions\Versions` is now a much simpler class that is no longer generated/written to disk at installation, and `ocramius/package-versions` is no longer a `"type": "composer-plugin"`, but rather a more usual `"type": "library"` package. This: * Fixes #138 - this library no longer changes `vendor` post-installation * Fixes #142 - the `rootPackage` version is now detected via composer, and no longer leads to changes in `vendor/ocramius/package-versions/src/PackageVersions/Versions.php` at each change of source root in a project * Fixes #152 - when `"lock": false` is used in composer, since we no longer access lock file information from sources of this package * Fixes #107 - writing to `vendor` is no longer happening from this library, so no file access rights should be needed.
Ocramius
force-pushed
the
fix/#138-#142-#152-#107-remove-the-need-for-generating-version-class
branch
from
ef69a97
to
b6d9c31
Compare
|
Curious failure: I think I'll kill off the whole e2e installer test 🤷 |
…ion is now a quite uneventful process This deletes months and months of ongoing efforts and struggle to keep things stable, but it's gone for a good reason, at least :-)
Ocramius
force-pushed
the
fix/#138-#142-#152-#107-remove-the-need-for-generating-version-class
branch
from
e3bd218
to
e9b0ace
Compare
Ocramius
deleted the
fix/#138-#142-#152-#107-remove-the-need-for-generating-version-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
This simplifies the tool to no longer be a plugin:
PackageVersions\Versionsis now a much simplerclass that is no longer generated/written to disk at installation, and
ocramius/package-versionsis no longer a
"type": "composer-plugin", but rather a more usual"type": "library"package.This:
vendorpost-installationrootPackageversion is now detected via composer, and no longer leads tochanges in
vendor/ocramius/package-versions/src/PackageVersions/Versions.phpat each changeof source root in a project
"lock": falseis used in composer, since we no longer access lock fileinformation from sources of this package
vendoris no longer happening from this library, so no file accessrights should be needed.