Add php:8.0.* support
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
force-pushed
the
feature/php-8.0.x-support
branch
from
d702ca0
to
e9282db
Compare
This patch explicitly adds `php:~8.0.0` support along with `php:^7.4.7`. `phpunit/phpunit` had to also be upgraded, so that it does not contain symbols that clash with the `php:8.0.0` parser BC breaks. To do so, we had to disable `infection/infection` reporting for now, as the mutation testing setup is not yet capable of working with `phpunit/phpunit:^9.3`. In addition to that, we now actively replace `composer/package-versions-deprecated`, which is constantly causing issues in installation, and which is fully replaced by this specific package. If you run `composer/composer:^2.0` and `php:8.0.0`, there is no reason to use `composer/package-versions-deprecated` anyway. Please note that the support for PHP is limited to `php:^7.4.7 || php:~8.0.0`: `php:8.1.0` is **NOT** supported by this release, as the upstream ecosystem is just too unstable and regularly breaks BC in multiple ways. Once `php:8.1.0-rc2` is out (possibly next year), work will be done to support that too.
Ocramius
force-pushed
the
feature/php-8.0.x-support
branch
from
e9282db
to
da77bb7
Compare
As per composer/composer#9302, this is a known composer bug that is not that relevant for this package for multiple reasons: 1. the only real dependencies are `php` and `composer-runtime-api`, which are fixed 2. we upgrade all dependencies whenever possible, and restrict the range too, via dependabot, so we don't keep old dependencies around for too long anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch explicitly adds
php:~8.0.0support along withphp:^7.4.7.phpunit/phpunithad to also be upgraded, so that it does not contain symbolsthat clash with the
php:8.0.0parser BC breaks.To do so, we had to disable
infection/infectionreporting for now, as themutation testing setup is not yet capable of working with
phpunit/phpunit:^9.3.In addition to that, we now actively replace
composer/package-versions-deprecated,which is constantly causing issues in installation, and which is fully replaced by
this specific package. If you run
composer/composer:^2.0andphp:8.0.0, there isno reason to use
composer/package-versions-deprecatedanyway.Please note that the support for PHP is limited to
php:^7.4.7 || php:~8.0.0:php:8.1.0is NOT supported by this release, as the upstream ecosystem is just too unstable
and regularly breaks BC in multiple ways. Once
php:8.1.0-rc2is out (possibly next year),work will be done to support that too.