Parse self.version in replaced packages #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
force-pushed
the
parse-replaced-versions
branch
from
168b29c
to
36e42b0
Compare
Ocramius
reviewed
Feb 5, 2018
| @@ -165,7 +165,12 @@ private static function getVersions(Locker $locker, RootPackageInterface $rootPa | |||
| } | |||
|
|
|||
| foreach ($rootPackage->getReplaces() as $replace) { | |||
| yield $replace->getTarget() => $replace->getPrettyConstraint() . '@' . $rootPackage->getSourceReference(); | |||
| $version = $replace->getPrettyConstraint(); | |||
| if ($version === 'self.version') { | |||
There was a problem hiding this comment.
Is there something other than self.version that we can add to the tests to demonstrate alternate outcomes? Or is this the only "special" version type in composer.json?
Ocramius
approved these changes
Feb 5, 2018
There was a problem hiding this comment.
Looked up https://github.com/Ocramius/PackageVersions/pull/59/files#r165964163, couldn't find anything, therefore shipping this one as-is 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #57 (comment)
[EDIT] Double push is due to rebase on master