Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies #93

Merged
merged 3 commits into from
Jun 18, 2019
Merged

updated dependencies #93

merged 3 commits into from
Jun 18, 2019

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 18, 2019

I guess this will fix #92

lets see what travis thinks

@@ -9,16 +9,16 @@
"packages-dev": [
{
"name": "composer/ca-bundle",
"version": "1.1.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update composer.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you meant we should update the composer.json to the latest available versions of the packages we depend on.
I did that with ece22f8

if you meant something different, just let me know. was a bit confued since composer/ca-bundle is only a transitive dependency which does not get mentioned in composer.json

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, thanks!

@Ocramius Ocramius added the bug label Jun 18, 2019
@Ocramius Ocramius added this to the 1.5.0 milestone Jun 18, 2019
@Ocramius
Copy link
Owner

Possibly needs a major version bump in PHPUnit

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

we cant bump to phpunit8 because that would drop php7.1 support

I guess the only viable solution right now is a "allow-failure" for php7.4 since there is no phpunit version which supports 7.1-7.4 - see https://phpunit.de/supported-versions.html

@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019 via email

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

That's fine, since the target for this is 1.5.0

so you mean we should drop php7.1 support and bump to phpunit8?

@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019 via email

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

uplifting php to 7.2 will shrink the possible userbase for this lib to ~25% of the actual php ecosystem - see https://seld.be/notes/php-versions-stats-2018-1-edition

I dont like this direction at all and I think its not a step in the correct direction to uplift the min-phpversion while stop to maintain older versions which are the lions share of the market. but at least you got what you asked for ;-).

@Ocramius Ocramius merged commit 9a8966e into Ocramius:master Jun 18, 2019
@Ocramius Ocramius self-assigned this Jun 18, 2019
@staabm staabm deleted the upd-phpunit branch June 18, 2019 17:24
@Ocramius
Copy link
Owner

That's what I do to all minor releases of all libraries I write: it is normal and expected. 1.4.x is still very much around

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

I am aware that you love this kind of "BC policy", but it makes consuming (and relying) on your libs very hard.

most of our products are on ubuntu16 lts boxes and those are stuck on php 7.0 until they get updated to ubuntu20, which is the next planned cycle.
even the newer boxes on our end with ubuntu18 just use php 7.2.

dropping php support for this versions that early (while not maintaining previous versions) for a rather new lib like this one which has still some rough edges (e.g. #91) forces us to maintain a fork of this lib which brings back the php 7.0 compat.

@Ocramius
Copy link
Owner

Ocramius commented Jun 18, 2019 via email

@Ocramius
Copy link
Owner

In practice: pin to ^1.4.0. if any new features land, then this is an incentive to upgrade overall.

I can also gladly maintain previous versions, but not for free.

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2019

Yeah, I see your point... its mostly the freetime for no-money thing, which I can totally agree with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures on PHP 7.4 build due to ReflectionType#__toString deprecations
2 participants