Merge pull request #417 from Ocramius/enhacement/use-proper-visibility

Use proper visibility when overwriting `TestCase#setUp()`
Ocramius · Jun 8, 2018 · 99542a2 · 99542a2
2 parents 80f3f9c + 85d2150
commit 99542a2
Show file tree

Hide file tree

Showing 16 changed files with 16 additions and 16 deletions.
diff --git a/tests/ProxyManagerBench/BaselinePropertyAccessBench.php b/tests/ProxyManagerBench/BaselinePropertyAccessBench.php
@@ -61,7 +61,7 @@ class BaselinePropertyAccessBench
      */
     private $accessMixedPropertiesProtected;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->privateProperties   = new ClassWithPrivateProperties();
         $this->protectedProperties = new ClassWithProtectedProperties();

diff --git a/tests/ProxyManagerBench/LazyLoadingGhostInstantiationBench.php b/tests/ProxyManagerBench/LazyLoadingGhostInstantiationBench.php
@@ -50,7 +50,7 @@ class LazyLoadingGhostInstantiationBench
      */
     private $mixedPropertiesProxy;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->emptyClassProxy          = $this->generateProxy(EmptyClass::class);
         $this->privatePropertiesProxy   = $this->generateProxy(ClassWithPrivateProperties::class);

diff --git a/tests/ProxyManagerBench/LazyLoadingGhostPropertyAccessBench.php b/tests/ProxyManagerBench/LazyLoadingGhostPropertyAccessBench.php
@@ -88,7 +88,7 @@ class LazyLoadingGhostPropertyAccessBench
      */
     private $initializedMixedPropertiesProxy;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->emptyClassProxy          = $this->buildProxy(EmptyClass::class);
         $this->privatePropertiesProxy   = $this->buildProxy(ClassWithPrivateProperties::class);

diff --git a/tests/ProxyManagerBench/LazyLoadingValueHolderInstantiationBench.php b/tests/ProxyManagerBench/LazyLoadingValueHolderInstantiationBench.php
@@ -50,7 +50,7 @@ class LazyLoadingValueHolderInstantiationBench
      */
     private $mixedPropertiesProxy;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->emptyClassProxy          = $this->generateProxy(EmptyClass::class);
         $this->privatePropertiesProxy   = $this->generateProxy(ClassWithPrivateProperties::class);

diff --git a/tests/ProxyManagerBench/LazyLoadingValueHolderPropertyAccessBench.php b/tests/ProxyManagerBench/LazyLoadingValueHolderPropertyAccessBench.php
@@ -54,7 +54,7 @@ class LazyLoadingValueHolderPropertyAccessBench
      */
     private $initializedMixedPropertiesProxy;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->emptyClassProxy          = $this->buildProxy(EmptyClass::class);
         $this->publicPropertiesProxy    = $this->buildProxy(ClassWithPublicProperties::class);

diff --git a/tests/ProxyManagerTest/Autoloader/AutoloaderTest.php b/tests/ProxyManagerTest/Autoloader/AutoloaderTest.php
@@ -39,7 +39,7 @@ class AutoloaderTest extends TestCase
     /**
      * @covers \ProxyManager\Autoloader\Autoloader::__construct
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->fileLocator        = $this->createMock(FileLocatorInterface::class);
         $this->classNameInflector = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/tests/ProxyManagerTest/ConfigurationTest.php b/tests/ProxyManagerTest/ConfigurationTest.php
@@ -32,7 +32,7 @@ class ConfigurationTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->configuration = new Configuration();
     }

diff --git a/tests/ProxyManagerTest/Factory/AbstractBaseFactoryTest.php b/tests/ProxyManagerTest/Factory/AbstractBaseFactoryTest.php
@@ -69,7 +69,7 @@ class AbstractBaseFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $configuration                 = $this->createMock(Configuration::class);
         $this->generator               = $this->createMock(ProxyGeneratorInterface::class);

diff --git a/tests/ProxyManagerTest/Factory/AccessInterceptorScopeLocalizerFactoryTest.php b/tests/ProxyManagerTest/Factory/AccessInterceptorScopeLocalizerFactoryTest.php
@@ -52,7 +52,7 @@ class AccessInterceptorScopeLocalizerFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->config                  = $this->createMock(Configuration::class);
         $this->inflector               = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/tests/ProxyManagerTest/Factory/AccessInterceptorValueHolderFactoryTest.php b/tests/ProxyManagerTest/Factory/AccessInterceptorValueHolderFactoryTest.php
@@ -51,7 +51,7 @@ class AccessInterceptorValueHolderFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->config                  = $this->createMock(Configuration::class);
         $this->inflector               = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/tests/ProxyManagerTest/Factory/LazyLoadingGhostFactoryTest.php b/tests/ProxyManagerTest/Factory/LazyLoadingGhostFactoryTest.php
@@ -49,7 +49,7 @@ class LazyLoadingGhostFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->config                  = $this->createMock(Configuration::class);
         $this->inflector               = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/tests/ProxyManagerTest/Factory/LazyLoadingValueHolderFactoryTest.php b/tests/ProxyManagerTest/Factory/LazyLoadingValueHolderFactoryTest.php
@@ -50,7 +50,7 @@ class LazyLoadingValueHolderFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->config                  = $this->createMock(Configuration::class);
         $this->inflector               = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/tests/ProxyManagerTest/Factory/NullObjectFactoryTest.php b/tests/ProxyManagerTest/Factory/NullObjectFactoryTest.php
@@ -50,7 +50,7 @@ class NullObjectFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->config                  = $this->createMock(Configuration::class);
         $this->inflector               = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/tests/ProxyManagerTest/Factory/RemoteObjectFactoryTest.php b/tests/ProxyManagerTest/Factory/RemoteObjectFactoryTest.php
@@ -51,7 +51,7 @@ class RemoteObjectFactoryTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->config                  = $this->createMock(Configuration::class);
         $this->inflector               = $this->createMock(ClassNameInflectorInterface::class);

diff --git a/...roxyGenerator/AccessInterceptorScopeLocalizer/MethodGenerator/BindProxyPropertiesTest.php b/...roxyGenerator/AccessInterceptorScopeLocalizer/MethodGenerator/BindProxyPropertiesTest.php
@@ -36,7 +36,7 @@ class BindProxyPropertiesTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->prefixInterceptors = $this->createMock(PropertyGenerator::class);
         $this->suffixInterceptors = $this->createMock(PropertyGenerator::class);

diff --git a/...yGenerator/AccessInterceptorScopeLocalizer/MethodGenerator/StaticProxyConstructorTest.php b/...yGenerator/AccessInterceptorScopeLocalizer/MethodGenerator/StaticProxyConstructorTest.php
@@ -35,7 +35,7 @@ class StaticProxyConstructorTest extends TestCase
     /**
      * {@inheritDoc}
      */
-    public function setUp()
+    protected function setUp()
     {
         $this->prefixInterceptors = $this->createMock(PropertyGenerator::class);
         $this->suffixInterceptors = $this->createMock(PropertyGenerator::class);