Skip properties when use ghost objects #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $properties | ||
| ); | ||
|
|
||
| $ghostObject->$propertyName; |
There was a problem hiding this comment.
This access will fail for private/protected properties. Also, you should assert on the value of the property once retrieved
malukenho
force-pushed
the
feature/allow-skipping-properties
branch
3 times, most recently
from
c0e6455
to
7d76711
Compare
| $publicProperties = new PublicPropertiesMap($originalClass); | ||
| $privateProperties = new PrivatePropertiesMap($originalClass); | ||
| $publicProperties = new PublicPropertiesMap($originalClass, $properties); | ||
| $privateProperties = new PrivatePropertiesMap($originalClass, $properties); | ||
| $protectedProperties = new ProtectedPropertiesMap($originalClass); |
There was a problem hiding this comment.
@Ocramius not because, I'm trying to make public and private pass first. But don't happens :'(
| @@ -36,6 +37,13 @@ class LazyLoadingGhostFactory extends AbstractLazyFactory | |||
| */ | |||
| private $generator; | |||
|
|
|||
| public function createProxy($className, Closure $initializer, array $properties = []) | |||
There was a problem hiding this comment.
Can probably be removed: $properties can go to the parent class IMO
| $this->assertArrayNotHasKey($propertyName, $filteredProperties->$methodToGetProperties()); | ||
| } | ||
|
|
||
| public function propertiesToSkipFixture() |
There was a problem hiding this comment.
Don't mix data providers and test methods. Move the data-provider to the bottom
malukenho
force-pushed
the
feature/allow-skipping-properties
branch
from
6cdb6e1
to
2a7d5cf
Compare
| new ReflectionClass(ClassWithMixedProperties::class) | ||
| ); | ||
|
|
||
| $this->assertArrayHasKey($propertyName, $properties->$methodToGetProperties()); |
There was a problem hiding this comment.
Can this simply be re-designed to use getInstanceProperties()? I don't like the dynamic method call here :-)
added 3 commits
January 8, 2015 02:44
…oading-ghost-should-return-boolean Hotfix: call initializer on lazy loading ghost should return boolean result
Ocramius
added a commit
that referenced
this pull request
Jan 8, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 8, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 8, 2015
|
@malukenho merged, thanks! |
Ocramius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#212