Fix #344 - lazy loading value holder magic method support #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g proxies (virtual proxies)
… triggering directly a notice
…re-existing method, where applicable
…sting method, where applicable
… pre-existing method, where applicable
…xisting method, where applicable
added 7 commits
October 22, 2016 15:10
Ocramius
commented
Oct 24, 2016
| if ($hasParent) { | ||
| $parameter = $originalClass->getMethod('__get')->getParameters()[0]; | ||
|
|
||
| $parameterType = $parameter->hasType() ? $parameter->getType() : null; |
There was a problem hiding this comment.
This is a fix for #346, no? Can you please revert it, and we move it to something else? We'd have to check it for all scenarios anyway...
| * @author Jefersson Nathan <malukenho@phpse.net> | ||
| * @license MIT | ||
| */ | ||
| class ClassWithMagicMethodsWeirdlyTypeHinted |
There was a problem hiding this comment.
Not weirdly :D Also - possibly to be delayed until #346
added 4 commits
October 24, 2016 08:49
|
@malukenho you said that you can't push 2.0.x or master? Did you already merge this change into those branches? |
|
@malukenho I un-protected |
Ocramius
changed the title
malukenho
deleted the
fix/#344-lazy-loading-value-holder-magic-method-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344
TODO:
3.1.0in PHP 7.1 support #327__get__set__unset__isset__get__set__unset__isset__get__set__unset__isset__get__set__unset__isset