Array access is broken in Virtual Proxies #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterrehm need review later today, I'll merge and tag 0.4.1 tomorrow if all is ok, since this is quite a serious bug :) Thanks again for the support! |
|
@Ocramius Glad we tracked the issue down. Looking forward to 0.4.1 then 👍 |
ghost
assigned
|
Added some tests to verify the behaviour of the newly introduced by-default-get-by-ref magic getter, since I wasn't sure about how it would work with other cases. |
Ocramius
added a commit
that referenced
this pull request
Jun 30, 2013
Array access is broken in Virtual Proxies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by @peterrehm, accessing public array properties in virtual proxies is currently broken