This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Updated PHPCR console class names #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new \Doctrine\ODM\PHPCR\Tools\Console\Command\RegisterSystemNodeTypesCommand(), | ||
| new \Jackalope\Tools\Console\Command\JackrabbitCommand(), | ||
| new \Jackalope\Tools\Console\Command\InitDoctrineDbalCommand(), | ||
| new \Jackalope\Tools\Console\Command\InitDoctrineDbalCommand() |
|
can you also fix |
| "doctrine/phpcr-odm": "dev-master", | ||
| "jackalope/jackalope-jackrabbit": "dev-master", | ||
| "jackalope/jackalope-doctrine-dbal": "dev-master", | ||
| "doctrine/phpcr-odm": "1.0.0", |
There was a problem hiding this comment.
no need to be so strict on the version numbers
There was a problem hiding this comment.
@lsmith77 we need to rely on some internal factories APIs because of how Zend\Di handles introspection on them - do you think it is safe to assume 1.0.* on each of those?
There was a problem hiding this comment.
very much so ..
btw we will soon wrap up 1.1 releases of both .. might make sense to test current master versions too and if things work also allow 1.1
There was a problem hiding this comment.
I don't mind changing it, but are you thinking 1.0.* or 1.* ?
There was a problem hiding this comment.
@milan 1.0.* - we can bump later on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the class names had changed in PHPCR which was erroring for me