Skip to content

Commit

Permalink
Update CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
beberlei committed Dec 14, 2013
1 parent d820c25 commit 4ed96e2
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -8,7 +8,7 @@ unified and future proof.

## We only accept PRs to "master"

Our branching strategy is summed up with "everything to master first", even
Our branching strategy is "everything to master first", even
bugfixes and we then merge them into the stable branches. You should only
open pull requests against the master branch. Otherwise we cannot accept the PR.

Expand All @@ -33,7 +33,7 @@ with some exceptions/differences:

## Unit-Tests

Always add a test for your pull-request.
Please try to add a test for your pull-request.

* If you want to fix a bug or provide a reproduce case, create a test file in
``tests/Doctrine/Tests/ORM/Functional/Ticket`` with the name of the ticket,
Expand All @@ -50,6 +50,12 @@ take a look at the ``tests/travis`` folder for some examples. Then run:

phpunit -c mysql.phpunit.xml

Tips for creating unittests:

1. If you put a test into the `Ticket` namespace as described above, put the testcase and all entities into the same class.
See `https://github.com/doctrine/doctrine2/tree/master/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2306Test.php` for an
example.

## Travis

We automatically run your pull request through [Travis CI](http://www.travis-ci.org)
Expand Down

0 comments on commit 4ed96e2

Please sign in to comment.