Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [bug] 4.2 absolute path is no more #39

Closed
OctoD opened this issue Sep 26, 2023 · 0 comments · Fixed by #41
Closed

🐛 [bug] 4.2 absolute path is no more #39

OctoD opened this issue Sep 26, 2023 · 0 comments · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@OctoD
Copy link
Owner

OctoD commented Sep 26, 2023

Describe the bug
In 4.2 devs can install an addon wherever they want, hence the absolute paths for loading scripts will be broken badly.

To Reproduce

  • Install 4.2
  • Add the addon on a directory different from addons
  • Boom

Expected behavior
Installing the addon in a specific folder should not break everything.

Additional context
Sigh

@OctoD OctoD added the bug Something isn't working label Sep 26, 2023
@OctoD OctoD self-assigned this Sep 26, 2023
OctoD added a commit that referenced this issue Sep 29, 2023
@OctoD OctoD mentioned this issue Sep 29, 2023
@OctoD OctoD closed this as completed in #41 Oct 3, 2023
OctoD added a commit that referenced this issue Oct 3, 2023
migalvalm added a commit to migalvalm/godot-gameplay-systems that referenced this issue Oct 17, 2023
* fix inventory in diablo_like example (OctoD#21)

Co-authored-by: sergwest <ksendzov.sd@gmail.com>

* chore: updates gitattributes

* chore: adds import file

* feat: adds hooks methods in Interaction (OctoD#22)

feat: adds on_before_interaction_end
feat: adds on_before_interaction_start
chore: updates sot-like example with draggable object

* chore: adds a line at the end so godot stop complaining

* Fix icon paths for attribute/ability resources/nodes (OctoD#24)

* fix icon paths missing "attributes_and_abilities"
* add available icons to ability nodes/resources

* fix abilitycontainer _ready missing preloaded abilities (OctoD#25)

* fix: fixes OctoD#26

* fix: adds condition

* chore(demo): adds example on how to use tags_to_display

* fix: closes OctoD#23 (OctoD#28)

* feat: adds _on_interaction_started and _on_interaction_ended calls (OctoD#29)

this occurs when an interactable_area is interacted and if the methods are implemented

(look at sot-like example)

* Feat/2d-and-3d-point-and-click-controllers (OctoD#30)

* feat: adds point_and_click_2d

* feat: adds PointAndClick3D node

* fix: fixes typo in tags_updated signal parameter name

* chore(docs): adds docs

* feat: adds radial menu (OctoD#31)

* chore: removes commented duped line

* feat: adds RadialMenuContainer icon

* chore: updates readme

* feat: adds initial camera shake implementation (OctoD#33)

* fix: closes OctoD#34. Thank you @Hairic95

* feat: adds SlideShow node for your game intros (OctoD#35)

* chore: migrates from 4.0 to 4.1

* fix: fixes test

* fix: fixes esc menu button

* chore: updates IDEAS.md

* feat: adds get_attributes_dict method

* Feat/turn-based-nodes (OctoD#36)

* feat: adds turn based nodes

* Update README.md (OctoD#42)

* fix: closes OctoD#39 (OctoD#41)

* chore: updates docs

* chore: adds requirement for reproj

---------

Co-authored-by: Sergwest <39670193+AFK1@users.noreply.github.com>
Co-authored-by: sergwest <ksendzov.sd@gmail.com>
Co-authored-by: octod <iamoctod@gmail.com>
Co-authored-by: OctoD <OctoD@users.noreply.github.com>
Co-authored-by: Daniel Bernard <daniel.john.bernard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant