Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under ListView, machines are randomly showing "No File Selected" under CurrentFile Column #1227

Closed
Firefighter1023 opened this issue Sep 25, 2022 · 11 comments
Labels
bug Something isn't working / good issue report released

Comments

@Firefighter1023
Copy link

OctoFarm Version

1.6.8

OctoPrint Version(s)

1.8.2

pm2 or docker?

pm2

Operating System

Debian/FarmPi

Description of the problem

When printers are working or in standby status the result is the same. Viewing the "list" view results in each of the printers randomly displaying the correct current file, or more often "No File Selected" in the current file column.

The top ribbon under current operations displays all correct information.

Steps taken to reproduce

Install OctoFarm 1.6.8
Connect many mutiple printers via OctoPi
All current file fields will mostly not populate or populate randomly
Refreshing the page multiple times results in random displays of the same information
Reconnecting all sockets, rebooting server, refreshing page all have no impact on the other fields

octofarm_dump-9-25-2022-10-40-48 AM.zip

@Firefighter1023 Firefighter1023 added the bug Something isn't working / good issue report label Sep 25, 2022
@swindmiller
Copy link

I noticed this too on 1.6.5, just updated to 1.6.8 and Current Operation showed I had a printer printing. List view showed Complete for the printer with no file loaded. Refreshed the page and it now showed Printing with a progress but still showed No File Selected. A few minutes later I returned to the tab (didn't close it) and it showed everything correct. Hopefully this help troubleshoot it.
Scott

@NotExpectedYet
Copy link
Member

What browsers are you both using?

@NotExpectedYet
Copy link
Member

Also Is there any sorting applied on the page? Or filtering?

Again I can't reproduce this with 30 printers been drawn on list view so I gather something is different here. I returned back to the old drawing method before 1.6.5 as well. The only thing that remains is checking if a printer is in view on the page before updating it.

I tested Firefox and Firefox developer edition and chrome developer edition and they were working fine with the implementation on my Linux box.

@NotExpectedYet
Copy link
Member

Let me know anyway I'll try get to it again this week.

@Firefighter1023
Copy link
Author

What browsers are you both using?

Tested in Chrome and IE on windows, Safari on IOS; I will check Firefox on Linux when I have a moment.

@Firefighter1023
Copy link
Author

Same result in firefox.

@NotExpectedYet
Copy link
Member

How strange. Cheers for trying those. I'll double check it's sounding like this is the in view detection so I will disable it over weekend until I can make sure it's working on more than just my browsers.

@NotExpectedYet
Copy link
Member

Huh, I disabled the inviewport check last update... what the hell is going on here then.

@NotExpectedYet
Copy link
Member

Think I've actually found the issue! woop

@NotExpectedYet
Copy link
Member

Wow that was annoying.

If anyone wants a work around until I get this next version released, then disable "Current Operations" on the view it's on.

NotExpectedYet added a commit that referenced this issue Oct 1, 2022
Current operations file element id was conflicting with the views file element id

Closes: #1227
NotExpectedYet added a commit that referenced this issue Oct 1, 2022
### [1.6.9](v1.6.8...v1.6.9) (2022-10-01)

### ➰ What a drag! ➰

* **client:** compile client down with babel support ([46015fb](46015fb))
* **client:** improve babel config ([300ba56](300ba56))
* **main:** add git ignore for new client development path ([719b9b6](719b9b6))
* **main:** fix development version assets not been found ([5c83d17](5c83d17))
* **main:** fix eslint rules triggering on top level reserved words ([b91bce4](b91bce4))
* **main:** update dependencies ([d98cb3e](d98cb3e))

### 🔨 Bug Fix 🔨

* **client:** conflict between current operation id and main views ([1ed2977](1ed2977)), closes [#1227](#1227)
* **client:** fix current operations sorting ([4ee3517](4ee3517)), closes [#1218](#1218)
* **client:** fix dashboard resizing ([ef022a0](ef022a0))
* **client:** incorrect path for background image ([a3091e5](a3091e5)), closes [#1234](#1234)
* **client:** unable to create new folders on op client ([61d4653](61d4653)), closes [#1226](#1226)
* **server:** a failed ip match would still attempt to be read ([89e543f](89e543f))
* **server:** couldn't parse octopi token when didn't exist ([00ceee7](00ceee7))
* **server:** normalise filenames before comparing for uniqeness ([e05c984](e05c984)), closes [#1233](#1233)
* **server:** unable to detach spools from printer ([20c3489](20c3489)), closes [#1232](#1232)

### 👗 UI! 👗

* **client:** split "view" button into "info" and "gallery" ([b3a1b0f](b3a1b0f))

### 😣 Code Refactor 😣

* **client:** increase length rounding so smaller values are displayed ([548cc98](548cc98))

### ❌ Removed ❌

* **client:** disable ability to edit and save spool changes ([b584d74](b584d74)), closes [#1217](#1217)
@NotExpectedYet
Copy link
Member

🎉 This issue has been resolved in version 1.6.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working / good issue report released
Projects
Development

No branches or pull requests

3 participants