Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spool Manager doesn't allow decimal prices #358

Closed
ksolomon opened this issue Mar 8, 2021 · 1 comment · Fixed by #369
Closed

Spool Manager doesn't allow decimal prices #358

ksolomon opened this issue Mar 8, 2021 · 1 comment · Fixed by #369
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
1.1.13 - Pushup Party

Comments

@ksolomon
Copy link

ksolomon commented Mar 8, 2021 •
edited

Client or Server side error
Client

Describe the bug
Price field in Spool Manager won't allow decimal prices

To Reproduce
Steps to reproduce the behavior:

  1. Go to Filament from top right menu
  2. Click on Spool Manager
  3. Enter price using a decimal (19.95 for example).
  4. Field highlights red, error on hover reads "Please select a valid value. The two nearest values are 19 and 20"

Expected behavior
Price should be added as entered

Screenshots
(Sorry it's a camera shot...no way to screenshot the error on hover)

photo_2021-03-08_11-13-27

Versions (please complete the following information):

  • NodeJS Version: 12.20.1
  • OctoFarm Version: 1.1.11
  • OctoPrint Version: N/A
  • OctoPrint Plugins: N/A

Additional context
Add any other context about the problem here.
@ksolomon ksolomon added the bug Something isn't working / good issue report label Mar 8, 2021
@NotExpectedYet
Copy link
Member

Ahh thanks for the screenshot. Is a quick fix so will get it sorted.

@NotExpectedYet NotExpectedYet moved this from To do to In progress in 1.1.13 - Pushup Party Mar 17, 2021
@NotExpectedYet NotExpectedYet moved this from In progress to Done in 1.1.13 - Pushup Party Mar 17, 2021
NotExpectedYet added a commit that referenced this issue Mar 17, 2021
@NotExpectedYet
update changelog - Fixed #358
45a4eaf
@NotExpectedYet NotExpectedYet mentioned this issue Mar 17, 2021
Merged
@NotExpectedYet NotExpectedYet linked a pull request Mar 17, 2021 that will close this issue
Bugfix/incorrect input steps filament manager #369
Merged
davidzwa added a commit that referenced this issue Mar 17, 2021
@NotExpectedYet
Bugfix/incorrect input steps filament manager (#369)
641333c 
* fix input fields to '0.01' decimals

* update changelog - Fixed #358

* Build gulp, whitespace and package json prerelease version

Co-authored-by: David Zwart <davidzwa@gmail.com>
@davidzwa davidzwa added the fixed on dev This issue has been fixed and is on its way label Mar 17, 2021
@NotExpectedYet NotExpectedYet mentioned this issue Mar 24, 2021
Closed
1.1.13 - Pushup Party automation moved this from Done to In progress Mar 24, 2021
@NotExpectedYet NotExpectedYet moved this from In progress to Done in 1.1.13 - Pushup Party Mar 24, 2021
@NotExpectedYet NotExpectedYet mentioned this issue Apr 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
No open projects
1.1.13 - Pushup Party
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/incorrect input steps filament manager OctoFarm/OctoFarm
3 participants
@ksolomon @davidzwa @NotExpectedYet