Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileManager: Cannot read property 'toFixed' of null #438

Closed
asd20752 opened this issue Apr 16, 2021 · 1 comment
Closed

FileManager: Cannot read property 'toFixed' of null #438

asd20752 opened this issue Apr 16, 2021 · 1 comment
Assignees
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way

Comments

@asd20752
Copy link

Client or Server side error
Server error
Error octofarm

Describe the bug
The bug occurred when I added a Prussa MK3 printer to OctoFarm. There is alot of files on the printer which showed up in OctoPrint.

To Reproduce
Do not know how to reproduse

Expected behavior
To see all the files on the printer

Screenshots
Error octofarm

Versions

Docker: 19.03.13
{
"Id": "sha256:ffc588835399000ca916346b7398f8b4745d6b288185f29d28679a5a034c5462",
"Digest": null,
"RepoDigests": [
"octofarm/octofarm@sha256:70f366079ab038078a51912729f4e133735b5d09f707a24b4587b74f1cd650b0"
],
"Labels": {
"org.opencontainers.image.created": "2021-03-05T07:50:06.839Z",
"org.opencontainers.image.description": "OctoFarm is an web server and client combination for unifying multiple instances of Octoprint. You can manage and monitor as many instances as you want from a single interface giving you full control over your 3D printer farm.",
"org.opencontainers.image.licenses": "AGPL-3.0",
"org.opencontainers.image.revision": "d5983dc8ca175c580380fb3585531bea6e280360",
"org.opencontainers.image.source": "https://github.com/OctoFarm/OctoFarm",
"org.opencontainers.image.title": "OctoFarm",
"org.opencontainers.image.url": "https://github.com/OctoFarm/OctoFarm",
"org.opencontainers.image.version": "master"
}
}

  • OS: Zorin 15.3
  • (docker container) OctoFarm Version 1.1.12
  • (docker container) OctoPrint Version 1.5.3
  • Firmware: Prusa-Firmware 3.9.3 based on Marlin

Additional context
I suspect that there is something in the file names that might be filtered out, or alternatively a off by one error.

@asd20752 asd20752 added the bug Something isn't working / good issue report label Apr 16, 2021
@NotExpectedYet
Copy link
Member

It's because of the statistics generation in the background on the server. Your files don't seem to have come with a size throwing off the calculation. I'll check on that, and move the toFixed off the page so it's not an issue at the very least.

NotExpectedYet added a commit that referenced this issue Apr 23, 2021
…on in pretty helpers. Stops the page failing when trying toFixed a string.
@NotExpectedYet NotExpectedYet moved this from To do to Done in 1.1.13 - Pushup Party Apr 23, 2021
@NotExpectedYet NotExpectedYet added the fixed on dev This issue has been fixed and is on its way label Apr 23, 2021
davidzwa pushed a commit that referenced this issue Apr 24, 2021
…on in pretty helpers. Stops the page failing when trying toFixed a string.
NotExpectedYet added a commit that referenced this issue Apr 24, 2021
#446)

* Fixed #438 - Moved toFixed() function inside the generateBytes function in pretty helpers. Stops the page failing when trying toFixed a string.

* changelog

* Fixed #438 - Moved toFixed() function inside the generateBytes function in pretty helpers. Stops the page failing when trying toFixed a string.

* changelog

* clean up of bytes function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
No open projects
Development

No branches or pull requests

2 participants