Bugfix/567 heatmap race condition #568
Conversation
| ] | ||
| }]) | ||
|
|
||
| expect(PrinterClean.initFarmInformation()).rejects.toThrow("Cannot read property 'x' of undefined"); |
There was a problem hiding this comment.
Our undefined bug, repro'd here. If the bug is prevented, this test will start to fail.
If the race-condition is fixed, this test will still see exceptions thrown.
Choice: patch the database object on the spot, or fix the race condition
There was a problem hiding this comment.
We could define the heat map in the database no? We'd only have to check for the day in the code if I remember rightly.
There was a problem hiding this comment.
See my change below, I think you're right but I saw incorrect duplication so maybe we can prevent this bug differently.
davidzwa
force-pushed
the
bugfix/567-heatmap-race-condition
branch
4 times, most recently
from
a2dcb91
to
57383de
Compare
|
I'll get this checked tomorrow and go through the file/job clean one once merged. |
davidzwa
force-pushed
the
bugfix/567-heatmap-race-condition
branch
from
07b3811
to
6a5e299
Compare
There was a problem hiding this comment.
Tested and all seems working from this end.
- Existing Mongo Local on PC issue was discovered: Result - Original database recovered.
- New Mongo Local on PC issue was discovered: Result - New database generated
- Existing mongo db on Atlas: Result - Original database recovered
- Remote mongo db on Atlas: Result - New Database Generated
Good spot!
Unrelated but small changes:
undefinedto "undefined" change (although not the cause of problems thusfar)filamentManagerrenamingfilamentManagerEnabledto avoid future headaches (either rename it all, or leave it untouched)