-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/546 node version abort page #570
Conversation
Oooo nice! Will take a snout at this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, will test it out.
5013042
to
53284c8
Compare
@NotExpectedYet its easy to test this with
|
53284c8
to
232b340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from it not loading the port this is lovely, good work man!
Gather I need to make an updating page on the OctoFarm site for this XD I clicked the link and it went no where bahaha.
Will add the dotenv config manually to prevent startup inconsistencies. I must add it cannot fully use startup checks in envUtils sadly, as it is and will not be Node 12 friendly (its so easy to make a mistake). Those checks involve writing a
Haha I did mention it in the PR description ;) |
That's fine too me, if it's first boot, ie no .env then default there anyway.
I did read it honest XD |
86bcca2
to
c4034de
Compare
c4034de
to
6980eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine, tried with custom port and all good.
Just went to add a ticket to the website git and your already there and done baha.
Epic man nice work.
nodejs update
Please test and review the external links I added.
Other fixes:
undefined
bug didnt boot properly (dotenv wasnt loaded yet)