Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated OP API call in state + backwards compat util #597

Merged
merged 8 commits into from
May 30, 2021
Merged

Fix deprecated OP API call in state + backwards compat util #597

merged 8 commits into from
May 30, 2021

Conversation

davidzwa
Copy link
Contributor

@davidzwa davidzwa commented May 25, 2021 •
edited

  • 1.6.0 - deprecated plugin API called
  • Wrong data taken from call
  • Undefined 'settingsAppearance' undefined check bug
  • Missing awaits (although async is unecessary)
  • Changelog

Furthermore:

  • Revert plugin back to repository.plugins
  • Fix compat check printer version
  • Test compat util

@davidzwa davidzwa linked an issue May 25, 2021 that may be closed by this pull request
state.js settingsAppearance undefined bug #598
Closed
@davidzwa davidzwa linked an issue May 25, 2021 that may be closed by this pull request
OctoPrint 1.6.0+ pluginmanager api deprecated - alternative available #596
Closed
davidzwa
davidzwa commented May 25, 2021
View reviewed changes
server_src/runners/state.js Outdated Show resolved Hide resolved
@davidzwa
Copy link
Contributor Author

image
1.5.3 and 1.5.2

image
1.6.0

@davidzwa davidzwa changed the title Fix multiple small bugs in state Fix deprecated OP API call in state + backwards compat util May 25, 2021
@davidzwa davidzwa added the fixed on dev This issue has been fixed and is on its way label May 25, 2021
NotExpectedYet
NotExpectedYet approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@NotExpectedYet NotExpectedYet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work man

@davidzwa davidzwa merged commit 14bc266 into development May 30, 2021
@davidzwa davidzwa deleted the bugfix/596-statejs-bugs branch May 30, 2021 05:10
NotExpectedYet
NotExpectedYet reviewed May 30, 2021
View reviewed changes
server_src/runners/state.js
@@ -2745,7 +2745,7 @@ class Runner {
}
}

async static getSettings(id) {
static async getSettings(id) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xD do this all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotExpectedYet NotExpectedYet NotExpectedYet approved these changes

Assignees
No one assigned
Labels
fixed on dev This issue has been fixed and is on its way
Projects
None yet
Milestone
No milestone
2 participants
@davidzwa @NotExpectedYet