Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab Support #113

Open
josephfrazier opened this issue Jun 29, 2016 · 13 comments
Open

GitLab Support #113

josephfrazier opened this issue Jun 29, 2016 · 13 comments
Labels
feature help wanted

Comments

@josephfrazier
Copy link
Member

josephfrazier commented Jun 29, 2016 •
edited

EDIT 2: Updated TODOs here: #113 (comment)

Hey @stefanbuck, I was just thinking I'd like to give this a try, but I'm wondering if you have any feedback on which parts of the code would need to be extended to support it (and of course, if it's something you'd be interested in merging). So far, I've thought of:

Here's an example of viewing a Gemfile on the two sites:

EDIT: Updated first list above with changes from #169
@stefanbuck
Copy link
Member

stefanbuck commented Jul 2, 2016 •
edited

Do you think there is a big demand for this? Until now, no one requested GitLab support. If anyone is interested in adding GitLab support, please let us know.

Anyway, in order to add GitLab support we have to touch parts which is also required to support GitHub enterprise #75. Maybe we should start with that first see #75 (comment). In a couple of weeks, we will see if this issue is trending or not 😉

@josephfrazier josephfrazier self-assigned this Aug 3, 2016
@parsingphase
Copy link

Bitbucket support also useful - let me know if you prefer a separate ticket.

@EricLanduyt
Copy link

Just discovered this extension, but at the same time that it is not supporting GitLab, so yes, definitely interested ! :)

@yisibl
Copy link

yisibl commented Aug 16, 2016

I hope we can customize the configuration.

@nogweii
Copy link

nogweii commented Aug 24, 2016

Another request for Gitlab support! Specifically, my own private instance, not just gitlab.com.

josephfrazier added a commit to josephfrazier/injection that referenced this issue Sep 1, 2016
@josephfrazier
Fall back to <html> if #js-repo-pjax-container is missing
9c8e2e0 
This allows this module to be used with [Turbolinks] sites like GitLab.
For a demo:

* Visit https://gitlab.com/gitlab-org/gitlab-ce
* Paste the contents of this file into the console
* Paste the following into the console:

```javascript
gitHubInjection(window, function(err) {
  if (err) {
    return console.error(err);
  }
  console.warn("XXX INJECTION");
});
```

* Click the "Activity" link
* Notice "XXX INJECTION" printed to the console

[Turbolinks]: https://github.com/turbolinks/turbolinks

See OctoLinker/OctoLinker#113
@josephfrazier josephfrazier mentioned this issue Sep 1, 2016
Open
@tomByrer
Copy link

tomByrer commented Sep 5, 2016 •
edited

FYI: somewhat popular JS author with a repo that I see around on occasion:
https://gitlab.com/Rich-Harris/buble

@nafg
Copy link

nafg commented Feb 28, 2017

Hi, what's the status of this?

@josephfrazier josephfrazier removed their assignment Feb 28, 2017
@josephfrazier
Copy link
Member Author

Hi @nafg, I haven't done any more work on this. If you or anyone else would be interested in picking it up, I'd be happy to provide pointers.

@nafg
Copy link

nafg commented Feb 28, 2017 via email

@josephfrazier
Copy link
Member Author

josephfrazier commented Feb 28, 2017 •
edited

Awesome, here's a (from memory) list of tasks to be done, ordered from easiest to hardest:

  • Change this line to just read the current domain, instead of hard-coding github.com
  • Get the changes in this pull request merged/released, then update this repo to use the new version. It will probably be easiest to make a pull request of your own, incorporating the changes from the other one, and then adding tests and bitbucket support as noted in the comments.
  • Extend the blob-reader to also support gitlab.com pages

After that, I think it will just be a matter of updating the browser extension metadata to have it run on gitlab.com urls as well as github.com, but that should be trivial. Feel free to ask any other questions you have.

@stefanbuck
Copy link
Member

One more thing, the additional permission for gitlab.com should be declared as a optional permission https://developer.chrome.com/extensions/permissions. I'm happy to help you with this.

@josephfrazier josephfrazier mentioned this issue Feb 28, 2017
Closed
@int64ago
Copy link

int64ago commented Oct 3, 2017

@josephfrazier Hi, thanks for the great work, any schedule for this?

@josephfrazier
Copy link
Member Author

@int64ago, I don't have time available to work on this at the moment. If you'd like to help out, refer to the task list above. I can offer advice or answer questions to support you along the way!

@fregante fregante mentioned this issue Aug 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Milestone
No milestone
Development

No branches or pull requests
9 participants
@nogweii @nafg @parsingphase @tomByrer @stefanbuck @int64ago @yisibl @josephfrazier @EricLanduyt