New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resolve.root in webpack #239

Open
shacharz opened this Issue Dec 27, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@shacharz

shacharz commented Dec 27, 2016

No description provided.

@josephfrazier

This comment has been minimized.

Show comment
Hide comment
@josephfrazier

josephfrazier Dec 28, 2016

Member

Hi @shacharz, thanks for the suggestion! Could you provide a description (or, preferably, a link to documentation) of how this should work?

Member

josephfrazier commented Dec 28, 2016

Hi @shacharz, thanks for the suggestion! Could you provide a description (or, preferably, a link to documentation) of how this should work?

@shacharz

This comment has been minimized.

Show comment
Hide comment
@shacharz

shacharz Dec 29, 2016

https://webpack.github.io/docs/configuration.html#resolve-root
I was thinking of being able to add those roots in the octolinker options, and maybe check those that you want out of all those you've used. If for example you're looking at a different repository that the currently used roots somehow mess with it.

shacharz commented Dec 29, 2016

https://webpack.github.io/docs/configuration.html#resolve-root
I was thinking of being able to add those roots in the octolinker options, and maybe check those that you want out of all those you've used. If for example you're looking at a different repository that the currently used roots somehow mess with it.

@josephfrazier

This comment has been minimized.

Show comment
Hide comment
@josephfrazier

josephfrazier Jan 2, 2017

Member

Thanks for the link. Another way this could work is that the extension reads the webpack.config.js file (similar to how #186 would work). That way, you wouldn't have to manually configure it.

Member

josephfrazier commented Jan 2, 2017

Thanks for the link. Another way this could work is that the extension reads the webpack.config.js file (similar to how #186 would work). That way, you wouldn't have to manually configure it.

@shacharz

This comment has been minimized.

Show comment
Hide comment
@shacharz

shacharz Jan 2, 2017

even better :)

shacharz commented Jan 2, 2017

even better :)

@pzrq

This comment has been minimized.

Show comment
Hide comment
@pzrq

pzrq Dec 20, 2017

FWIW, as an extensive user of webpack's resolve.alias in things derived from compass-plugin, I think resolve.root from @shacharz comments and / or resolve.alias would be really awesome to have.

CC @matt-d-rat

pzrq commented Dec 20, 2017

FWIW, as an extensive user of webpack's resolve.alias in things derived from compass-plugin, I think resolve.root from @shacharz comments and / or resolve.alias would be really awesome to have.

CC @matt-d-rat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment