Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance. 250ms to initialize #38

Closed
paulirish opened this issue Aug 15, 2015 · 4 comments
Closed

Performance. 250ms to initialize #38

paulirish opened this issue Aug 15, 2015 · 4 comments

Comments

@paulirish
Copy link

On my macbook air, this extension pauses the load of the page for 250ms while it compiles and runs:

image

image

The upfront parsing is what really kills it. I am guessing because of the enormous JSON blob.

To profile this i'm using about:tracing in chrome which gives you this level of detail.
@stefanbuck
Copy link
Member

Hi @paulirish
thanks for raising an issue with helpful information. I'm thinking since a while about a bigger refactoring of the extension to get ride of the JSON file. My idea is to evaluate the package names on the fly without a lookup list or even just for the most popular packages. Unfortunately I'm busy with my new flat, but I will try to find a solution soon as possible.

stefanbuck referenced this issue Aug 19, 2015
@stefanbuck
3.6.0.2
afae006
@stefanbuck
Copy link
Member

Just a quick status update on this. I'm currently working on a service, which will be soon responsible for the mapping. I'm very happy to get ride of these JSON files. Thanks for pushing me @paulirish 😉

https://github.com/github-linker/live-resolver

@paulirish
Copy link
Author

most good!​

@stefanbuck
Copy link
Member

Fix in v.3.8.0

@stefanbuck stefanbuck mentioned this issue Sep 5, 2015
Closed
josephfrazier added a commit to josephfrazier/browser-extension that referenced this issue Jan 15, 2018
@josephfrazier
package.json: Specify Node ^7.6.0 as engine (OctoLinker#38)
c410ff4 
This allows newer Node versions to be used.
josephfrazier added a commit to josephfrazier/browser-extension that referenced this issue Jan 15, 2018
@josephfrazier
Travis: test on latest Node v7 (OctoLinker#39)
d2515a0 
c410ff4 (OctoLinker#38) caused the heroku [deploy] to use Node v7.7.4 instead of
v7.6.0, so let's make sure to test on the latest Node as well.

[deploy]: https://travis-ci.org/OctoLinker/live-resolver/builds/215311723#L386-L387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @stefanbuck