Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby require_relative fixes #1014

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Ruby require_relative fixes #1014

merged 4 commits into from
Sep 1, 2020

Conversation

MatthewDG
Copy link
Contributor

Issue #773

Checklist:

  • If this PR is a new feature, please provide at least one example link
  • Make sure all of the significant new logic is covered by tests

@xt0rted xt0rted linked an issue Aug 31, 2020 that may be closed by this pull request
Ruby relative requires are broken #773
Closed
xt0rted
xt0rted approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@xt0rted xt0rted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanbuck the tests are passing and the examples work, this looks good to me.

stefanbuck
stefanbuck approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@stefanbuck stefanbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@stefanbuck
Copy link
Member

Amazing, thanks for this contribution @MatthewDG.

@stefanbuck stefanbuck merged commit 710f36e into OctoLinker:master Sep 1, 2020
@MatthewDG MatthewDG deleted the 773-ruby-require-fixes branch September 1, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xt0rted xt0rted xt0rted approved these changes

@stefanbuck stefanbuck stefanbuck approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby relative requires are broken
3 participants
@MatthewDG @stefanbuck @xt0rted