Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test NOT annotation #1046

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Add e2e test NOT annotation #1046

merged 2 commits into from
Oct 2, 2020

Conversation

stefanbuck
Copy link
Member

@stefanbuck stefanbuck commented Sep 30, 2020 •
edited
Loading

Pull Request Badge

As discussed in #1033 (comment) this PR introduce a NOT annotation

// @OctoLinkerDoesNotResolve
require('ftp://foo.bar')

xt0rted
xt0rted approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@xt0rted xt0rted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

e2e/automated.test.js Outdated Show resolved Hide resolved
@stefanbuck @xt0rted
Update e2e/automated.test.js
742c5b4 
Co-authored-by: Brian Surowiec <brian@13degrees.com>
@stefanbuck stefanbuck merged commit f925986 into main Oct 2, 2020
@stefanbuck stefanbuck deleted the e2e-annotation-not branch October 2, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xt0rted xt0rted xt0rted approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanbuck @xt0rted