Persist update notification on reload #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
commented
Mar 8, 2020
| @@ -24,6 +24,8 @@ export const set = async (key, value) => { | |||
| [key]: value, | |||
| }; | |||
|
|
|||
| Object.assign(store, data); | |||
There was a problem hiding this comment.
This change is needed to reflect a set call immediately. Before this was delayed until OctoLinker got invoked another time.
|
it seems in FF the notitifaction does not disappear after clicking its "X" edit: to be more precise: it disappears, but reappears on the next page load |
|
Thanks for reporting, I'll look into this soon! In the meantime, the Addons preference settings allows you to disable update notifications
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I was talking to friend and he made me aware of an issue with the update notification. The update notification appears immediately whenever the extension updates. If a user navigates to another GitHub page or performs a page reload, the notification is gone forever. With this change we persist the notification state until a user interaction happens (either close or following the link)