Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use some shortcuts in the versioning script #866

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Use some shortcuts in the versioning script #866

merged 4 commits into from
Apr 1, 2020

Conversation

fregante
Copy link
Collaborator

I found some small improvements could be made, feel free to reject if you find it trivial.

Sadly dot-json doesn't support merging arrays or else you could drop the json dependency.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@stefanbuck stefanbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, looks much simpler. Do you mind updating the patch-permissions npm script as well so we can remove json as a dependency? Once this is done I'm more than happy to merge this.

@fregante
Copy link
Collaborator Author

Updating how? Dot-json can’t do that

@stefanbuck
Copy link
Member

Ohh I didn't noticed that dot-json is unable to add additional fields. In that case we can keep it or consider adding the permission as you suggested. I'm just concerned about asking for any additional permission which seem to be unnecessary for Chrome users.

@stefanbuck
Copy link
Member

Looks like the updated package-lock.json file is missing and therefore breaking the CI

@stefanbuck
Copy link
Member

Amazing, thank you @fregante

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants