-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use some shortcuts in the versioning script #866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, looks much simpler. Do you mind updating the patch-permissions
npm script as well so we can remove json
as a dependency? Once this is done I'm more than happy to merge this.
Updating how? Dot-json can’t do that |
Ohh I didn't noticed that |
Looks like the updated |
Amazing, thank you @fregante |
This reverts commit 1d8406f.
I found some small improvements could be made, feel free to reject if you find it trivial.
Sadly dot-json doesn't support merging arrays or else you could drop the
json
dependency.