Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Dynamic Imports #315

Closed
jamiebuilds opened this issue Mar 17, 2017 · 2 comments
Closed

JavaScript Dynamic Imports #315

jamiebuilds opened this issue Mar 17, 2017 · 2 comments

Comments

@jamiebuilds
Copy link

OctoLinker version: 4.9.0

JavaScript is adding dynamic imports which look like this:

import("./module") // >> Promise<Module>

OctoLinker doesn't appear to support these yet, it would be nice if it did.

@josephfrazier
Copy link
Member

This seems like it should be relatively straight-forward to implement, if anyone would like to. You'll need to change require(\.resolve)? to ( require(\.resolve)? | import ) here, then port some valid and invalid tests into the corresponding forms using the dynamic import syntax.

@robotjsorg
Copy link
Contributor

robotjsorg commented Mar 20, 2017

Hi, I am not sure how the CI works, but I forked and created a branch called Issue-#315.
Pull #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants