Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for modern browsers #10

Closed
wants to merge 6 commits into from
Closed

Update for modern browsers #10

wants to merge 6 commits into from

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Jul 7, 2017

Follows #9

@coveralls
Copy link

coveralls commented Jul 7, 2017 •
edited

Coverage Status

Coverage decreased (-44.4%) to 18.75% when pulling 05d47c4 on bfred-it:future into 80ddc56 on OctoLinker:master.

@fregante
Copy link
Contributor Author

fregante commented Jul 7, 2017

Quick support question. Mocha seems to have gone nuts on my computer, it cached index.js somewhere and doesn't respond to changes to it. At all. Even if I empty the file the test result is always the same as it was earlier. Node is loading the correct file (because if I delete index.js it throws) but the tests don't change. :(

stefanbuck
stefanbuck approved these changes Jul 8, 2017
View reviewed changes
Copy link
Member

@stefanbuck stefanbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, will release a new version soon. Thanks for making all this changes

@stefanbuck
Copy link
Member

Oh there's one remaining failing test. Can you please fix this

@fregante
Copy link
Contributor Author

fregante commented Jul 8, 2017

I can't because of the issue I described. The tests literally don't respond to my changes anymore, it seems 😕

@josephfrazier
Copy link
Member

What happens if you remove node_modules and reinstall? If you have a globally installed version of mocha, you might want to remove it as well.

@stefanbuck
Copy link
Member

Sorry, missed your comment. That's really strange, I can have a look later today

@fregante fregante mentioned this pull request Jul 9, 2017
Closed
@fregante fregante closed this Jul 10, 2017
@fregante fregante deleted the future branch July 10, 2017 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanbuck stefanbuck stefanbuck approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fregante @coveralls @stefanbuck @josephfrazier