Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: octomap & octomath target conflicts with ninja generator and Visual Studio #321

Open
SpaceIm opened this issue Feb 8, 2021 · 1 comment · May be fixed by #419
Open

CMake: octomap & octomath target conflicts with ninja generator and Visual Studio #321

SpaceIm opened this issue Feb 8, 2021 · 1 comment · May be fixed by #419

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 8, 2021

octomap can't be built with Visual Studio and ninja generator because CMakeLists builds both static and shared, and OUTPUT_NAME of shared and static targets are identical. Therefore static lib and import lib of dll have the same name.
This is illegal with ninja when both targets live in the same dependency tree.

One solution would be to give a different name to the static or shared lib if Visual Studio.

Moreover it would be nice to provide options to disable shared or static (we have to patch CMakeLists of octomap and octomath in the public repository of conan (package manager) because its policy is to provide either static or shared depending on an option, not both in the same package).

@ahornung
Copy link
Member

Thanks for the input! Are there standard / common options to use to disable either static or shared libs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants