Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error when path for saving octomap is invalid #108

Merged
merged 2 commits into from
Jun 22, 2022
Merged

fix: throw error when path for saving octomap is invalid #108

merged 2 commits into from
Jun 22, 2022

Conversation

wep21
Copy link

@wep21 wep21 commented Jun 22, 2022

Closes #103.

  • throw error when path for saving octomap is invalid
  • add instruction to save octomap

Daisuke Nishimatsu added 2 commits June 23, 2022 00:05
fix: throw error when path name is invalid
b9fe990 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
docs: add instruction to save octomap
51687da 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Jun 22, 2022

@wxmerkt Could you review this PR?

@wep21 wep21 mentioned this pull request Jun 22, 2022
Closed
@wxmerkt wxmerkt merged commit ff5ded9 into OctoMap:ros2 Jun 22, 2022
@wxmerkt
Copy link
Member

wxmerkt commented Jun 22, 2022

Thank you very much for providing a fix!

@wep21 wep21 deleted the fix/throw-error branch June 22, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxmerkt wxmerkt wxmerkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wep21 @wxmerkt