Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Migration #14

Merged
merged 5 commits into from
Dec 12, 2021
Merged

ROS2 Migration #14

merged 5 commits into from
Dec 12, 2021

Conversation

wep21
Copy link

@wep21 wep21 commented Dec 12, 2021

No description provided.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Dec 12, 2021

@wxmerkt I created a PR for ros2 migration. Could you create a branch named ros2? And then, I will change the target branch.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
wep21 added 3 commits December 13, 2021 01:06
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wxmerkt wxmerkt changed the base branch from melodic-devel to ros2 December 12, 2021 18:36
@wxmerkt wxmerkt changed the title Feature/ros2 migration ROS2 Migration Dec 12, 2021
@wxmerkt
Copy link
Member

wxmerkt commented Dec 12, 2021

Dear @wep21
Thank you very much for the contribution. I've created the new branch and changed the target. Is this branch ready for merging then?

Best wishes,
Wolfgang

@wep21
Copy link
Author

wep21 commented Dec 12, 2021

@wxmerkt Thanks for creating the branch. Yes, this is ready for merging. Also, I appreciate it if you could create a release PR toward rosdistro via bloom.

@wep21
Copy link
Author

wep21 commented Dec 12, 2021

@wxmerkt Could you re-run github action before merging this just in case though I have already checked it on my fork repository?
https://github.com/wep21/octomap_ros/runs/4498633705?check_suite_focus=true

@wxmerkt
Copy link
Member

wxmerkt commented Dec 12, 2021

Great, thank you for confirming. The GitHub Actions will only run once they are merged.

@cottsay - could you please create a octomap_ros release repository in ros2-gbp?

@wxmerkt wxmerkt merged commit b419432 into OctoMap:ros2 Dec 12, 2021
@wep21
Copy link
Author

wep21 commented Dec 13, 2021

@wxmerkt Thank you for creating a release repositroy. ros/rosdistro#31473
Could you also create a PR for galactic and rolling?

@wxmerkt
Copy link
Member

wxmerkt commented Dec 14, 2021

I'm planning to create PRs for galactic and rolling once the one for foxy is merged and has successfully built

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants