Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarlinBFT and probably all methods broken with OctoPrint 1.9.0rc2 #341

Closed
The-EG opened this issue Mar 10, 2023 · 10 comments
Closed

MarlinBFT and probably all methods broken with OctoPrint 1.9.0rc2 #341

The-EG opened this issue Mar 10, 2023 · 10 comments

Comments

@The-EG
Copy link

The-EG commented Mar 10, 2023

Hardware Setup
Ender 3 Pro with an BTT Octopus v1.1

Describe the problem
Flashing is broken when using MarlinBFT method on OctoPrint 1.9.0rc2. After selecting the bin file and pressing 'Flash From File' the progress bar displays "Flashing Firmware" and nothing happens.

The browser console shows a 400 (BAD REQUEST) error for the /plugin/firmwareupdater/flash url.

There are no errors in the octoprint.log (attached anyway).

Log Files

octoprint.log

Additional context
Issue caused by changes in latest OctoPrint release candidate version.

@benlye
Copy link
Collaborator

benlye commented Mar 10, 2023

Just want to set expectations - I'm travelling for work and probably won't be able to look into this for at least a week.

@benlye
Copy link
Collaborator

benlye commented Mar 10, 2023

Could you try the devel version of the plugin?

@The-EG
Copy link
Author

The-EG commented Mar 11, 2023

Could you try the devel version of the plugin?

Same result with version 1.14.0b2.

@benlye
Copy link
Collaborator

benlye commented Mar 17, 2023

I just got to give this a try. Interesting results...

My installation already had plugin v1.14.0b2 and after updating to OctoPrint v1.9.0rc2 I had no problems flashing the firmware. I downgraded my plugin to v1.13.3 and got the 400 error, I then upgraded to v1.14.0b2 and I still get the 400 error.

This is going to be fun.

@The-EG
Copy link
Author

The-EG commented Mar 17, 2023

You can reproduce it at least, I'll take it!

I did poke around a bit, it doesn't appear to be even making it to the /flash route.

@benlye
Copy link
Collaborator

benlye commented Mar 17, 2023

I think I have the fix for this - please test v1.14.0b3 from the plugin's Development branch.

@benlye
Copy link
Collaborator

benlye commented Mar 17, 2023

The solution was actually provided in #323 - all I had to do was merge the PR. Thanks, @arekm.

@The-EG
Copy link
Author

The-EG commented Mar 17, 2023

Great, I'll take a look this evening.

@The-EG
Copy link
Author

The-EG commented Mar 18, 2023

Confirmed, 1.14.0b3 resolves this for me on OctoPrint 1.9.0rc2.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants