Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Select the first tool by default, when there is only one tool on the printer #3738

Closed
LRTNZ opened this issue Sep 20, 2020 · 11 comments
Labels
done Done but not yet released improvement Improving functionality, behaviour, UX, ... request Feature request
Milestone

Comments

@LRTNZ
Copy link

LRTNZ commented Sep 20, 2020

Issue/Fustration

I am often fustrated when I go to the control tab of OctoPrint, to run some plastic through my hotend to prime it (Say when changing colour) , by the fact I have to select the tool before I can use it - especially when it is the only tool on the printer.

Ideal Solution

When there is only one tool on the printer, for that to always be the default selected tool.

Potentially to build on this, if there are multiple tools, have an easy and obvious way for the user to quickly select and change the default tool (Say you run different nozzle sizes, and are planning to work with one particular size for a few days, having a way inside the control tab to mark the default tool would be great), which will work in the same way, being the one selected by default.

Altenatives

I am not sure what other alternatives there really are, to a default selection of the one and only tool?

Additional Context

It is really only an ease of life thing, that I think may remove a tiny bit of fustration from the days of all users that use the control tab to run filament through their extruder.

@github-actions github-actions bot added the request Feature request label Sep 20, 2020
@cp2004
Copy link
Member

cp2004 commented Sep 20, 2020

If you don't select a tool, I think it extrudes through the previously selected one, which for single extruder is always just T0, so it extrudes anyway. Is this the case for you?
If this is correct, then maybe it is a bug that it shows select tool with just one tool 🤷
I think the UI with selection could be improved too, since it does not show which tool has been selected:
toolselect

@cp2004 cp2004 added the improvement Improving functionality, behaviour, UX, ... label Sep 20, 2020
@jneilliii
Copy link
Contributor

jneilliii commented Sep 20, 2020

I think this would definitely be better to automatically select the first one by default on page load and making the selected one actually show up.

Edit: it's using boostrap's dropdown-toggle so that is what is probably preventing it from showing the selected one. It's just a button.

@LRTNZ
Copy link
Author

LRTNZ commented Sep 20, 2020

If you don't select a tool, I think it extrudes through the previously selected one, which for single extruder is always just T0, so it extrudes anyway. Is this the case for you?

I would test that right now... But I am in the middle of building up my Benchy Armada, so I cannot really do that rn 😅

If this is correct, then maybe it is a bug that it shows select tool with just one tool 🤷

Yes, I think that may be the case.

I think the UI with selection could be improved too, since it does not show which tool has been selected:
toolselect

That's odd... I could have sworn that I have seen the text in the button change to be the tool that I have selected?
I am using Version 1.4.2, based on what is on the "about OctoPrint" window.

@LRTNZ
Copy link
Author

LRTNZ commented Sep 20, 2020

That's odd... I could have sworn that I have seen the text in the button change to be the tool that I have selected?

NVM, it does not show the tool that has been selected... Print just detached itself from the bed, so got to test earlier than planned 😢

@cp2004 cp2004 added the triage This issue needs triage label Sep 20, 2020
@foosel
Copy link
Member

foosel commented Sep 21, 2020

Tool selection isn't required, and displaying the currently selected tool there isn't possible as I cannot query that data from the firmware and it can be changed either through the controller or GCODE on the printer's SD and thus without OctoPrint noticing it.

I will see that it is clearer that you only need to select something if you want to change the active tool, and I will also make the whole selection box hide if there's only one.

@foosel
Copy link
Member

foosel commented Sep 21, 2020

Single extruder setup:

image

Multi extruder setup:

image

Popover:

image

Will be part of 1.5.0.

@foosel foosel added done Done but not yet released and removed triage This issue needs triage labels Sep 21, 2020
@foosel foosel added this to the 1.5.0 milestone Sep 21, 2020
@LRTNZ
Copy link
Author

LRTNZ commented Sep 21, 2020

Looks great! I wonder if down the line support for reading the selected tool is something that could be added by the Marlin team? That should cover the majority of printers?

@foosel
Copy link
Member

foosel commented Sep 21, 2020

Possibly yes, alas, the majority of printers out there actually (according to my tracking) do not run mainline Marlin but forks, and from my experience it takes eons for fixes and improvements to make their way first downstream to the forks and then on actual printers. Most users rarely flash, and if so flash whatever their printer's vendor provides them with, which rarely is mainline Marlin.

@LRTNZ
Copy link
Author

LRTNZ commented Sep 21, 2020

Possibly yes, alas, the majority of printers out there actually (according to my tracking) do not run mainline Marlin but forks, and from my experience it takes eons for fixes and improvements to make their way first downstream to the forks and then on actual printers. Most users rarely flash, and if so flash whatever their printer's vendor provides them with, which rarely is mainline Marlin.

Yeah, I can certainly see the issue there - maybe if it got into the Prusa fork, it could get out to at least some printers - as their ones squawk like anything when there is an update available for them 😅

@foosel foosel closed this as completed in dd78fd3 Nov 30, 2020
@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/what-happened-to-select-tool/26932/13

@cp2004
Copy link
Member

cp2004 commented Dec 1, 2020

According to the linked ticket, RepRapFirmware requires a T0 command even with just one extruder. This should either be done automatically, or an option to re-show the button.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released improvement Improving functionality, behaviour, UX, ... request Feature request
Projects
None yet
Development

No branches or pull requests

5 participants