Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin install hangs if URL returns a 404 #3886

Closed
cp2004 opened this issue Dec 14, 2020 · 5 comments
Closed

Plugin install hangs if URL returns a 404 #3886

cp2004 opened this issue Dec 14, 2020 · 5 comments
Labels
approved Issue has been approved by the bot or manually for further processing bug Issue describes a bug done Done but not yet released

Comments

@cp2004
Copy link
Member

cp2004 commented Dec 14, 2020

What were you doing?

  1. Install plugin from URL, eg:
https://github.com/cp2004/OctoPrint-EEPROM-Marlin/archive/3.0.0r3.zip

which should be

https://github.com/cp2004/OctoPrint-EEPROM-Marlin/archive/3.0.0rc3.zip

but there is a typo.

What did you expect to happen?

Error was reported to the user

What happened instead?

Unhandled exception in plugin manager thread, and install window hangs:

Exception in thread Thread-137:
Traceback (most recent call last):
  File "C:\Program Files\Python38\lib\threading.py", line 932, in _bootstrap_inner
    self.run()
  File "C:\Program Files\Python38\lib\threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\charl.TERRANCE\OneDrive\Documents\8. Coding Projects\5. Octoprint\OctoPrint\src\octoprint\plugins\pluginmanager\__init__.py", line 631, in command_install
    path = download_file(url, folder.name)
  File "c:\users\charl.terrance\onedrive\documents\8. coding projects\5. octoprint\octoprint\src\octoprint\util\net.py", line 254, in download_file
    r.raise_for_status()
  File "C:\Users\charl.TERRANCE\OneDrive\Documents\8. Coding Projects\5. Octoprint\OctoPrint\venv3\lib\site-packages\requests\models.py", line 941, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://codeload.github.com/cp2004/OctoPrint-EEPROM-Marlin/zip/3.0.0r3

Did the same happen when running OctoPrint in safe mode?

Unable to test, since plugin install is not possible under safe mode.

Version of OctoPrint

1.5.x (& maintenance branch)

Operating System running OctoPrint

Windows 10, and OctoPi 0.17

Printer model & used firmware incl. version

VIRTUAL

Browser and version of browser, operating system running browser

Edge Version 87.0.664.60 (Official build) (64-bit)

Link to octoprint.log

https://gist.github.com/cp2004/6a4b4ff600fadcd6b0f41529baa0ece4

Link to contents of terminal tab or serial.log

NA

Link to contents of Javascript console in the browser

Nothing of note beyond the usual here (and I would notice, I've stared at that log hundreds of times now)

Screenshot(s)/video(s) showing the problem:

image

I have read the FAQ.

@github-actions github-actions bot added the triage This issue needs triage label Dec 14, 2020
@GitIssueBot GitIssueBot added the approved Issue has been approved by the bot or manually for further processing label Dec 14, 2020
@cp2004 cp2004 added bug Issue describes a bug and removed triage This issue needs triage labels Dec 14, 2020
@cp2004
Copy link
Member Author

cp2004 commented Dec 14, 2020

In addition (and it might be related) the undervoltage state is not reported to the frontend, maybe it is related to #3849

@kantlivelong
Copy link
Contributor

Submitted #3889

@foosel foosel added pr pending A pull request addressing this has been submitted but not yet merged done Done but not yet released and removed pr pending A pull request addressing this has been submitted but not yet merged labels Jan 11, 2021
@foosel
Copy link
Member

foosel commented Jan 11, 2021

Thank for that, merged to maintenance and ready for 1.6.0

@foosel foosel added this to the 1.6.0 milestone Jan 11, 2021
@cp2004
Copy link
Member Author

cp2004 commented Jan 19, 2021

1.5.3 has been released

@cp2004 cp2004 closed this as completed Jan 19, 2021
@foosel foosel removed this from the 1.6.0 milestone Jan 19, 2021
@foosel foosel modified the milestone: 1.6.0 Mar 29, 2021
@foosel
Copy link
Member

foosel commented Mar 29, 2021

Consider me mightily puzzled whether this actually made it into 1.5.3 just now and thus a milestone set/reset storm.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Issue has been approved by the bot or manually for further processing bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

4 participants